Support Fragments for intra document markdown editor links#19639
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Jan 31, 2017
Merged
Support Fragments for intra document markdown editor links#19639mjbvz merged 1 commit intomicrosoft:masterfrom
mjbvz merged 1 commit intomicrosoft:masterfrom
Conversation
Adds support for editor links with fragements for markdown. This jumps to the correct header location if one can be found
|
@mjbvz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joaomoreno and @jrieken to be potential reviewers. |
jrieken
reviewed
Feb 24, 2017
| } | ||
| return uri; | ||
|
|
||
| return vscode.Uri.parse(`command:_markdown.openDocumentLink?${encodeURIComponent(JSON.stringify({ fragment: uri.fragment, path: resourcePath }))}`); |
Member
There was a problem hiding this comment.
This is a lot of code for using an URI that goes like this: file:///files/thisFile.md#L22. Unless there are bugs which I would happily fix, the OpenerService should handle such links correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for clicking editor links with fragements in the markdown editor:
Clicking on the link jumps to the correct header in the target document